fix: adding labels in combo box (default combo box, with default value) #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trussworks/react-uswds-design-owners I'll review this PR 👍 |
rileyorr
previously approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Great job on this - LGTM!
The only thing I might consider either as part of this PR or a separate one is potentially removing the With Label use case since the default combo box already includes a label. It might help clean up the documentation; however, it might impact teams already using that component.
brandonlenz
reviewed
Oct 25, 2023
| @@ -72,7 +74,7 @@ export const withLabel = (): React.ReactElement => { | |||
|
|
|||
| return ( | |||
| <Form onSubmit={noop}> | |||
| <Label htmlFor="fruit">Select a fruit</Label> | |||
| <Label htmlFor="fruit">Select a Fruit</Label> | |||
There was a problem hiding this comment.
The labels should be sentence case (see USWDS example):
Suggested change
| <Label htmlFor="fruit">Select a Fruit</Label> | |
| <Label htmlFor="fruit">Select a fruit</Label> |
There was a problem hiding this comment.
(Same for the others added on this PR)
|
Hello @brandonlenz, Can you kindly review my PR |
brandonlenz
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to the USWDS docs the combo box should always have a label. Some of the examples in the storybook do not have labels. So the commit adds labels in the component file
src/components/forms/ComboBox/ComboBox.stories.tsxto avoid confusion that they are optional.Related Issues or PRs
Closes #2608
How To Test
Screenshots (optional)