Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding labels in combo box (default combo box, with default value) #2636

Merged
merged 6 commits into from
Nov 3, 2023
+6 −4
Merged

fix: adding labels in combo box (default combo box, with default value) #2636

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98b242c
fix: hard coding labels in combo box (default combo box, with default…
m7adeel Oct 22, 2023
02ebba4
Merge branch 'trussworks:main' into m7adeel-combo_box-label
m7adeel Oct 23, 2023
fcabaf2
Merge branch 'main' into m7adeel-combo_box-label
m7adeel Oct 25, 2023
4cb9640
fix: updating to sentence case
m7adeel Oct 25, 2023
180d6a5
Merge branch 'main' into m7adeel-combo_box-label
m7adeel Oct 30, 2023
4fcdb34
Merge branch 'main' into m7adeel-combo_box-label
m7adeel Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/forms/ComboBox/ComboBox.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export const defaultComboBoxWithPropOptions = (): React.ReactElement => {

return (
<Form onSubmit={noop}>
<Label htmlFor="input-ComboBox">Select a fruit</Label>
<ComboBox
id="input-ComboBox"
name="input-ComboBox"
Expand All @@ -53,6 +54,7 @@ export const withDefaultValue = (): React.ReactElement => {

return (
<Form onSubmit={noop}>
<Label htmlFor="input-ComboBox">Select a fruit</Label>
<ComboBox
id="input-ComboBox"
name="input-ComboBox"
Expand Down Expand Up @@ -92,7 +94,7 @@ export const disabled = (): React.ReactElement => {

return (
<Form onSubmit={noop}>
<Label htmlFor="fruit">Select a Fruit</Label>
<Label htmlFor="fruit">Select a fruit</Label>
<ComboBox
id="fruit"
name="fruit"
Expand All @@ -112,7 +114,7 @@ export const withOtherFields = (): React.ReactElement => {

return (
<Form onSubmit={noop}>
<Label htmlFor="fruit">Select a Fruit</Label>
<Label htmlFor="fruit">Select a fruit</Label>
<ComboBox id="fruit" name="fruit" options={fruitList} onChange={noop} />
<Label htmlFor="fruitDescription">Description</Label>
<TextInput id="fruitDescription" name="fruitDescription" type="text" />
Expand All @@ -133,7 +135,7 @@ export const exposedRefMethods = (): React.ReactElement => {

return (
<Form onSubmit={noop}>
<Label htmlFor="fruit">Select a Fruit</Label>
<Label htmlFor="fruit">Select a fruit</Label>
<ComboBox
id="fruit"
name="fruit"
Expand Down Expand Up @@ -176,7 +178,7 @@ export const customInputChangeHandler = (): React.ReactElement => {

return (
<Form onSubmit={noop}>
<Label htmlFor="fruit">Select a Fruit</Label>
<Label htmlFor="fruit">Select a fruit</Label>
<ComboBox
id="fruit"
name="fruit"
Expand Down
Loading