-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address a bunch of pedantic clippy lints #106
Conversation
I looked over your changes roughly and it looks great to me! I had been working on something similar, as well, but I did not have the time to upload it. I planned to add more restrictive Clippy lints, see #92, and the changes you submitted are a very good step towards that. There is only one thing I would like to ask you to change: would you please change the lint level from "warn" to "deny"? In #92, the discussion was mostly about the "deny" level, so I think this would be a good enhancement. |
Thanks for the PR @danieleades! Great to see that @kevinmatthes gives his go. #92 can then nicely expand on this work. I merged #107 already, if you could solve the conflicts this one will follow 👍. |
these might not all be of interest, so i've split them into separate commits for ease of review