Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address a bunch of pedantic clippy lints #106

Merged
merged 14 commits into from
Apr 9, 2023
Merged

address a bunch of pedantic clippy lints #106

merged 14 commits into from
Apr 9, 2023

Commits on Apr 9, 2023

  1. use semicolons if nothing returned

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    3fa4d99 View commit details
    Browse the repository at this point in the history

  2. avoid using wildcard imports

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    8cf2b1f View commit details
    Browse the repository at this point in the history

  3. prefer 'copy' to 'clone'

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    8460e82 View commit details
    Browse the repository at this point in the history

  4. prefer 'if let' to 'match' for single option

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    886d90e View commit details
    Browse the repository at this point in the history

  5. prefer exhaustive match blocks

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    3500250 View commit details
    Browse the repository at this point in the history

  6. don't 'match' on boolean expressions

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    665e0b9 View commit details
    Browse the repository at this point in the history

  7. remove unnecessary negations

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    e7deffa View commit details
    Browse the repository at this point in the history

  8. remove unused 'async'

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    fcc9ddc View commit details
    Browse the repository at this point in the history

  9. use inline format args

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    71c1412 View commit details
    Browse the repository at this point in the history

  10. prefer explicit clone

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    e7d8819 View commit details
    Browse the repository at this point in the history

  11. use consistent struct field order

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    33a5044 View commit details
    Browse the repository at this point in the history

  12. use 'Self' keyword to refer to own type

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    05d2187 View commit details
    Browse the repository at this point in the history

  13. use 'const'

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    832cbd0 View commit details
    Browse the repository at this point in the history

  14. elevate warnings to 'deny'

    @danieleades
    danieleades committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    bfd0c57 View commit details
    Browse the repository at this point in the history