Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed uploads are kept in the TusURLStore when resuming is enabled #26

Closed
jjrodrig opened this issue May 14, 2019 · 2 comments
Closed

Completed uploads are kept in the TusURLStore when resuming is enabled #26

jjrodrig opened this issue May 14, 2019 · 2 comments

Comments

@jjrodrig
Copy link

remove(String fingerprint) is never called for TusURLStore after a completed upload

The upload fingerprints are kept at the TusURLStore, this coul be a problem if a persistent URLStore is used as in the Android client where the PreferencesStore is used with this purpose.

Which is the expected behaviour? Should'nt be removed from the URLStore?
@Acconut
Copy link
Member

Acconut commented May 15, 2019

Which is the expected behaviour?

Yes, this is the currently expected behavior. tus-java-client does not remove fingerprints at the moment and it would be the task of the library user to take care of cleaning up the URL storage.

Should'nt be removed from the URLStore?

There are situations in which the URLs should be cleaned up after the upload is finished and there are other situations where this should not happen. That's why tus-js-client, for example, has the removeFingerprintOnSuccess option (see https://github.com/tus/tus-js-client/#tusdefaultoptions) which removes the entry for the URL storage. tus-java-client has no comparable option but we are happy to accept a PR for that feature!

jjrodrig pushed a commit to jjrodrig/tus-java-client that referenced this issue May 21, 2019
tus#26 Add support for removeFingerprintOnSuccess config property
ebb5eab
@jjrodrig jjrodrig mentioned this issue May 21, 2019
Closed
Acconut added a commit that referenced this issue Jun 13, 2019
@Acconut
Add feature to remove fingerpints after successful upload
003ff8a 
See #27

Squashed commit of the following:

commit b664f5b11b406d1ecf9b8fb5e2286de15641cc15
Author: Marius <maerious@gmail.com>
Date:   Thu Jun 13 12:16:27 2019 +0200

    Move line endings back to Unix's LF

commit b5807b8
Author: Juan Jose Rodriguez <jj.rodriguez@lks.es>
Date:   Tue Jun 4 17:16:59 2019 +0200

    Change uploadFinished visibility to protected

commit ebb5eab
Author: Juan Jose Rodriguez <jj.rodriguez@lks.es>
Date:   Tue May 21 14:41:37 2019 +0200

    #26 Add support for removeFingerprintOnSuccess config property
@Acconut
Copy link
Member

Acconut commented Jun 13, 2019

This feature has been implemented in #27

@Acconut Acconut closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for removeFingerprintOnSuccess config property jjrodrig/tus-java-client
2 participants
@jjrodrig @Acconut