Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for removeFingerprintOnSuccess config property #27

Closed
wants to merge 2 commits into from
Closed

Add support for removeFingerprintOnSuccess config property #27

wants to merge 2 commits into from

Conversation

jjrodrig
Copy link

This PR adds removeFingerprintOnSuccess config property to TusClient that allows to define whether the upload URL should be removed from the URL store after a successful upload.

This behaviour is disabled by default and should be enabled by calling:

TusClient.enableRemoveFingerprintOnSuccess()

Closes #26 issue

@Acconut
Copy link
Member

Acconut commented Jun 2, 2019

Thank you for this PR and your patience.

I had a thorough look at your patch and there are two topic I would like to talk about:

  • Could you explain what the mockito dependency is about? I never heard about it so I am wondering if it's necessary.
  • Could you make the uploadFinished method package private? I don't think there is a need of it being public.

jjrodrig
jjrodrig commented Jun 3, 2019
View reviewed changes
build.gradle Show resolved Hide resolved
@jjrodrig
Copy link
Author

jjrodrig commented Jun 3, 2019

Thanks @Acconut
I've included my responses as comments in the code review

Acconut added a commit that referenced this pull request Jun 13, 2019
@Acconut
Add feature to remove fingerpints after successful upload
003ff8a 
See #27

Squashed commit of the following:

commit b664f5b11b406d1ecf9b8fb5e2286de15641cc15
Author: Marius <maerious@gmail.com>
Date:   Thu Jun 13 12:16:27 2019 +0200

    Move line endings back to Unix's LF

commit b5807b8
Author: Juan Jose Rodriguez <jj.rodriguez@lks.es>
Date:   Tue Jun 4 17:16:59 2019 +0200

    Change uploadFinished visibility to protected

commit ebb5eab
Author: Juan Jose Rodriguez <jj.rodriguez@lks.es>
Date:   Tue May 21 14:41:37 2019 +0200

    #26 Add support for removeFingerprintOnSuccess config property
@Acconut
Copy link
Member

Acconut commented Jun 13, 2019

Thank you for the changes. I fixed a few trailing whitespace issues and also converted your Windows CRLF line endings back to Unix's LF.

Merged in 003ff8a.

@Acconut Acconut closed this Jun 13, 2019
@Acconut Acconut mentioned this pull request Jun 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acconut Acconut Acconut left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completed uploads are kept in the TusURLStore when resuming is enabled
2 participants
@jjrodrig @Acconut