Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Promise return type for onBeforeRequest and onAfterResponse. #212

Merged
merged 10 commits into from
Aug 31, 2020
Merged

Allow Promise return type for onBeforeRequest and onAfterResponse. #212

merged 10 commits into from
Aug 31, 2020

Conversation

Mentthew
Copy link
Contributor

No description provided.

@Acconut
Copy link
Member

Acconut commented Jul 22, 2020

Thanks for the PR! Can you add a test case and update the documentation as well?

@Mentthew Mentthew closed this Jul 22, 2020
@Mentthew Mentthew reopened this Jul 22, 2020
@Mentthew
Copy link
Contributor Author

Thanks for the PR! Can you add a test case and update the documentation as well?

Done. ;)

dragoscirjan and others added 8 commits July 29, 2020 17:23
@dragoscirjan @Acconut
@dependabot @kvz
Allow to specify options for Node's request method (tus#203)
715cade 
* adding nodejs HttpStack request options

* fix

* fix

* fix

* visual fix

* proposal for request options

* disabling browser

* fix

* Clarify how to import using ESM syntax

* Added onShouldRetry callback for controlling retries (tus#198)

* Added onShouldRetry callback for controlling retry

Whenever the library is about to retry an upload due to an
error, the new optional callback onShouldRetry will be
called when defined. Its return value will tell the library whether
to actually retry the upload or fail with an error, for example
based on status code checks.

This makes it possible to customize the behavior like reacting on
specific status codes.

* Move onShouldRetry example to usage.md

* Refactored shouldRetry logic

- isOnline is now excluded from the check, so the onShouldRetry callback
  should manually add an online check if desired
- removed inline function and made the conditions more readable
- clarified inline comments about status code check

* Add test assertion for onShouldRetry arguments

* Update usage.md

* Update test-common.js

* Update api.md

Co-authored-by: Marius <marius.kleidl@gmail.com>

* making property 'private', adding small test for 'insecure' request

* fixes ?

* fix: import

* Update js-base64 to a version which does not use eval() anymore

Closes tus#147

* PR comments fixes

* fixed exports on node, addex HttpStack export on browser

* added new test case - node 14

* test fixes

* test fixes

* fix tests

* Bump lodash from 4.17.14 to 4.17.19

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.14...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

* Clean up request initialization and add proper test

Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com>
Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com>
Co-authored-by: Marius <marius@transloadit.com>
Co-authored-by: Vincent Petry <pvince81@owncloud.com>
Co-authored-by: Marius <marius.kleidl@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com>
@dependabot
Bump elliptic from 6.3.1 to 6.5.3 (tus#214)
764d34f 
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.3.1 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.3.1...v6.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Acconut
Update dependencies using 'npm audit fix'
2628615
@Acconut
Do not pass URL as separate parameter
ff40d08 
This is not supported in Node.js 8 and 9.
@Acconut
Downgrade tsd to support Node.js 8 and 9
d3695e5 
See https://github.com/SamVerschueren/tsd/releases/tag/v0.12.1
@kbs-odd
Correct type definition for Upload#terminate (tus#217)
46d7471 
inconsistency between typescript typing and function definition
@Acconut
Merge branch 'promise-before_after-request' of https://github.com/Men…
a2cbee7 
…tthew/tus-js-client into Mentthew-promise-before_after-request
@Acconut
Minor cleanups
eed6361
Acconut
Acconut approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@Acconut Acconut merged commit b6907d8 into tus:master Aug 31, 2020
Acconut added a commit that referenced this pull request Aug 31, 2020
@bedgerotto @kbs-odd
@Mentthew @dragoscirjan @Acconut @dependabot @kvz
Add onBeforeRequest and onAfterResponse to terminate method (#216)
9b57f0a 
* #209 Add onBeforeRequest and onAfterResponse to terminate method

* Call onAfterResponse even if the request was not successfull

* Correct type definition for Upload#terminate (#217)

inconsistency between typescript typing and function definition

* Allow Promise return type for onBeforeRequest and onAfterResponse. (#212)

* Allow Promise return type for onBeforeRequest and onAfterResponse.

* Allow Promise return type for onBeforeRequest and onAfterResponse: documentation and test case.

* Allow to specify options for Node's request method (#203)

* adding nodejs HttpStack request options

* fix

* fix

* fix

* visual fix

* proposal for request options

* disabling browser

* fix

* Clarify how to import using ESM syntax

* Added onShouldRetry callback for controlling retries (#198)

* Added onShouldRetry callback for controlling retry

Whenever the library is about to retry an upload due to an
error, the new optional callback onShouldRetry will be
called when defined. Its return value will tell the library whether
to actually retry the upload or fail with an error, for example
based on status code checks.

This makes it possible to customize the behavior like reacting on
specific status codes.

* Move onShouldRetry example to usage.md

* Refactored shouldRetry logic

- isOnline is now excluded from the check, so the onShouldRetry callback
  should manually add an online check if desired
- removed inline function and made the conditions more readable
- clarified inline comments about status code check

* Add test assertion for onShouldRetry arguments

* Update usage.md

* Update test-common.js

* Update api.md

Co-authored-by: Marius <marius.kleidl@gmail.com>

* making property 'private', adding small test for 'insecure' request

* fixes ?

* fix: import

* Update js-base64 to a version which does not use eval() anymore

Closes #147

* PR comments fixes

* fixed exports on node, addex HttpStack export on browser

* added new test case - node 14

* test fixes

* test fixes

* fix tests

* Bump lodash from 4.17.14 to 4.17.19

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.14...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

* Clean up request initialization and add proper test

Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com>
Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com>
Co-authored-by: Marius <marius@transloadit.com>
Co-authored-by: Vincent Petry <pvince81@owncloud.com>
Co-authored-by: Marius <marius.kleidl@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com>

* Bump elliptic from 6.3.1 to 6.5.3 (#214)

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.3.1 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.3.1...v6.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update dependencies using 'npm audit fix'

* Do not pass URL as separate parameter

This is not supported in Node.js 8 and 9.

* Downgrade tsd to support Node.js 8 and 9

See https://github.com/SamVerschueren/tsd/releases/tag/v0.12.1

* Correct type definition for Upload#terminate (#217)

inconsistency between typescript typing and function definition

* Minor cleanups

Co-authored-by: Dragos Cirjan <dragos.cirjan+github2@gmail.com>
Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com>
Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com>
Co-authored-by: Marius <marius@transloadit.com>
Co-authored-by: Vincent Petry <pvince81@owncloud.com>
Co-authored-by: Marius <marius.kleidl@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com>
Co-authored-by: kabaliserv <66329463+kabaliserv@users.noreply.github.com>

* Allow to return Promises in onBeforeRequest for terminate

Co-authored-by: kabaliserv <66329463+kabaliserv@users.noreply.github.com>
Co-authored-by: Mentthew <34655639+Mentthew@users.noreply.github.com>
Co-authored-by: Dragos Cirjan <dragos.cirjan+github2@gmail.com>
Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com>
Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com>
Co-authored-by: Marius <marius@transloadit.com>
Co-authored-by: Vincent Petry <pvince81@owncloud.com>
Co-authored-by: Marius <marius.kleidl@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acconut Acconut Acconut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mentthew @Acconut @dragoscirjan @kbs-odd