Update index.d.ts #217
Merged
Update index.d.ts #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inconsistency between typescript typing and function definition
Acconut
added a commit
that referenced
this pull request
Aug 31, 2020
) * Allow Promise return type for onBeforeRequest and onAfterResponse. * Allow Promise return type for onBeforeRequest and onAfterResponse: documentation and test case. * Allow to specify options for Node's request method (#203) * adding nodejs HttpStack request options * fix * fix * fix * visual fix * proposal for request options * disabling browser * fix * Clarify how to import using ESM syntax * Added onShouldRetry callback for controlling retries (#198) * Added onShouldRetry callback for controlling retry Whenever the library is about to retry an upload due to an error, the new optional callback onShouldRetry will be called when defined. Its return value will tell the library whether to actually retry the upload or fail with an error, for example based on status code checks. This makes it possible to customize the behavior like reacting on specific status codes. * Move onShouldRetry example to usage.md * Refactored shouldRetry logic - isOnline is now excluded from the check, so the onShouldRetry callback should manually add an online check if desired - removed inline function and made the conditions more readable - clarified inline comments about status code check * Add test assertion for onShouldRetry arguments * Update usage.md * Update test-common.js * Update api.md Co-authored-by: Marius <marius.kleidl@gmail.com> * making property 'private', adding small test for 'insecure' request * fixes ? * fix: import * Update js-base64 to a version which does not use eval() anymore Closes #147 * PR comments fixes * fixed exports on node, addex HttpStack export on browser * added new test case - node 14 * test fixes * test fixes * fix tests * Bump lodash from 4.17.14 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.14...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> * Clean up request initialization and add proper test Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com> Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com> Co-authored-by: Marius <marius@transloadit.com> Co-authored-by: Vincent Petry <pvince81@owncloud.com> Co-authored-by: Marius <marius.kleidl@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com> * Bump elliptic from 6.3.1 to 6.5.3 (#214) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.3.1 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.3.1...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dependencies using 'npm audit fix' * Do not pass URL as separate parameter This is not supported in Node.js 8 and 9. * Downgrade tsd to support Node.js 8 and 9 See https://github.com/SamVerschueren/tsd/releases/tag/v0.12.1 * Correct type definition for Upload#terminate (#217) inconsistency between typescript typing and function definition * Minor cleanups Co-authored-by: Dragos Cirjan <dragos.cirjan+github2@gmail.com> Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com> Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com> Co-authored-by: Marius <marius@transloadit.com> Co-authored-by: Vincent Petry <pvince81@owncloud.com> Co-authored-by: Marius <marius.kleidl@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com> Co-authored-by: kabaliserv <66329463+kabaliserv@users.noreply.github.com>
Acconut
added a commit
that referenced
this pull request
Aug 31, 2020
* #209 Add onBeforeRequest and onAfterResponse to terminate method * Call onAfterResponse even if the request was not successfull * Correct type definition for Upload#terminate (#217) inconsistency between typescript typing and function definition * Allow Promise return type for onBeforeRequest and onAfterResponse. (#212) * Allow Promise return type for onBeforeRequest and onAfterResponse. * Allow Promise return type for onBeforeRequest and onAfterResponse: documentation and test case. * Allow to specify options for Node's request method (#203) * adding nodejs HttpStack request options * fix * fix * fix * visual fix * proposal for request options * disabling browser * fix * Clarify how to import using ESM syntax * Added onShouldRetry callback for controlling retries (#198) * Added onShouldRetry callback for controlling retry Whenever the library is about to retry an upload due to an error, the new optional callback onShouldRetry will be called when defined. Its return value will tell the library whether to actually retry the upload or fail with an error, for example based on status code checks. This makes it possible to customize the behavior like reacting on specific status codes. * Move onShouldRetry example to usage.md * Refactored shouldRetry logic - isOnline is now excluded from the check, so the onShouldRetry callback should manually add an online check if desired - removed inline function and made the conditions more readable - clarified inline comments about status code check * Add test assertion for onShouldRetry arguments * Update usage.md * Update test-common.js * Update api.md Co-authored-by: Marius <marius.kleidl@gmail.com> * making property 'private', adding small test for 'insecure' request * fixes ? * fix: import * Update js-base64 to a version which does not use eval() anymore Closes #147 * PR comments fixes * fixed exports on node, addex HttpStack export on browser * added new test case - node 14 * test fixes * test fixes * fix tests * Bump lodash from 4.17.14 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.14...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> * Clean up request initialization and add proper test Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com> Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com> Co-authored-by: Marius <marius@transloadit.com> Co-authored-by: Vincent Petry <pvince81@owncloud.com> Co-authored-by: Marius <marius.kleidl@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com> * Bump elliptic from 6.3.1 to 6.5.3 (#214) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.3.1 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.3.1...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dependencies using 'npm audit fix' * Do not pass URL as separate parameter This is not supported in Node.js 8 and 9. * Downgrade tsd to support Node.js 8 and 9 See https://github.com/SamVerschueren/tsd/releases/tag/v0.12.1 * Correct type definition for Upload#terminate (#217) inconsistency between typescript typing and function definition * Minor cleanups Co-authored-by: Dragos Cirjan <dragos.cirjan+github2@gmail.com> Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com> Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com> Co-authored-by: Marius <marius@transloadit.com> Co-authored-by: Vincent Petry <pvince81@owncloud.com> Co-authored-by: Marius <marius.kleidl@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com> Co-authored-by: kabaliserv <66329463+kabaliserv@users.noreply.github.com> * Allow to return Promises in onBeforeRequest for terminate Co-authored-by: kabaliserv <66329463+kabaliserv@users.noreply.github.com> Co-authored-by: Mentthew <34655639+Mentthew@users.noreply.github.com> Co-authored-by: Dragos Cirjan <dragos.cirjan+github2@gmail.com> Co-authored-by: Dragos Cirjan <dragos.cirjan@cellebrite.com> Co-authored-by: Dragos Cirjan <dragos.cirjan@gmail.com> Co-authored-by: Marius <marius@transloadit.com> Co-authored-by: Vincent Petry <pvince81@owncloud.com> Co-authored-by: Marius <marius.kleidl@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin van Zonneveld <vanzonneveld@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inconsistency between typescript typing and function definition