Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha 6 ignoring _custom.scss #21583

Closed
bluesurfer opened this issue Jan 6, 2017 · 4 comments
Closed

Alpha 6 ignoring _custom.scss #21583

bluesurfer opened this issue Jan 6, 2017 · 4 comments
Labels

Comments

@bluesurfer
Copy link

I am trying to customize Bootstrap by editing _custom.scss like this:

$blue: red !default

But, when compiling with grunt dist-css, the new version seem to ignore _custom.scss - nothing changes. On the other hand editing directly _variables.scss works. Am I missing something new or is this an actual bug?

@maimairel
Copy link

This is caused by #21442 I also have the same issue

@mdo
Copy link
Member

mdo commented Jan 6, 2017

Drop the !default. https://jsbin.com/ficofo/edit?html,css,output

@mdo mdo closed this as completed Jan 6, 2017
@mdo mdo added css v3 v4 and removed v3 labels Jan 6, 2017
@maimairel
Copy link

@mdo Yes, I don't have the !default on the custom values. What I don't understand is while $grid-breakpoints and $container-max-widths do work the other custom values are ignored.

@szastupov
Copy link
Contributor

I can confirm the issue, here is my _custom.scss:

$brand-primary:             #f0941c;
$brand-inverse:             #0f6be3;
$brand-danger:              #e15325;
$body-color:                #505455;

and all those variables are ignored.

The reasons is that values from _variables.scss are used in mixins before including _custom.scss.

Here is your modified example to demo the behaviour: https://jsbin.com/qutoniseci/edit?html,css,output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants