Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_custom.scss should be the first include #21603

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Conversation

desheikh
Copy link
Contributor

@desheikh desheikh commented Jan 8, 2017

Custom include should be at the top of the file. This prevents issues where for example reassigning $brand-primary would not affect any of the other variables using $brand-primary.

@bardiharborow
Copy link
Member

This reverts #21442. Ref #21595. @mdo any idea what's going on here?

@szastupov
Copy link
Contributor

Ref #21583

@mdo
Copy link
Member

mdo commented Jan 9, 2017

@bardiharborow The problem I was trying to solve before is that folks cannot use existing variables and mixins in the _custom.scss file if it comes first in the import order. My hope was moving it to come after the variables and mixins would solve things, but now folks can't update the value of variables that are reassigned in our _variables.scss file (e.g., $link-color using $brand-primary).

So, we're kinda screwed either way. I don't think we can have both in Sass. I think I'd rather change it back though.

Thoughts?

@judetucker
Copy link

+1 for change it back. I think it's more common for people to use it for overriding the bootstrap default vars

@mdo mdo added this to the v4.0.0-beta milestone Jan 10, 2017
@mdo mdo merged commit e7035ae into twbs:v4-dev Jan 10, 2017
@mdo mdo mentioned this pull request Jan 10, 2017
@Starsam80
Copy link
Contributor

This PR doesn't change the files bootstrap-grid.scss and bootstrap-reboot.scss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants