Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Move _custom.scss after vars and mixins #21442

Merged
merged 4 commits into from
Dec 27, 2016
Merged

v4: Move _custom.scss after vars and mixins #21442

merged 4 commits into from
Dec 27, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Dec 27, 2016

Allows reuse of vars and mixins, while also allowing customization of vars. Fixes #21409.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Dec 27, 2016
@mdo mdo merged commit fe0573c into v4-dev Dec 27, 2016
@mdo mdo mentioned this pull request Dec 27, 2016
@maimairel
Copy link

maimairel commented Jan 6, 2017

I'm not sure if sass works this way, but after moving _custom.scss after _variables.scss, some variables inside _custom.scss are ignored. I have $gray-dark set to #000000 inside _custom.scss, but the compiled CSS have it still its default value. What doesn't make sense is, $grid-breakpoints and $container-max-widths do work while the other custom values are ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants