-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New build system - htmllint errors (on Windows only?) #22535
Comments
You're not alone @patrickhlauke when I ran |
FYI |
Current |
so how can this be a windows only issue? is some tool before the lint step not generating the same output? is the linting not happening the same way? because the errors the linter is reporting are indeed valid errors, and i'm surprised they've not been picked up before... |
@peterblazejewicz |
Could it be possible that Jekyll is giving different outputs between Windows and other OS's |
now that #22500 is merged, i don't get the errors anymore...but intrigued still why it seemed to only happen on windows. if the errors were just about spaces, i could have understood potential win/macOS/ubuntu differences. but as the linting errors were quite substantive ( |
@patrickhlauke
npm run docs-lint
> bootstrap@4.0.0-alpha.6 docs-lint /Users/piotrblazejewicz/git/bootstrap
> htmlhint --config docs/.htmlhintrc _gh_pages/ js/tests/visual/ && htmllint --rc docs/.htmllintrc --cwd _gh_pages/ && htmllint --rc docs/.htmllintrc --cwd js/tests/visual/
Config loaded: docs/.htmlhintrc
Config loaded: docs/.htmlhintrc
Scanned 101 files, no errors found (1626 ms).
[htmllint] found 0 errors out of 91 files
[htmllint] found 0 errors out of 10 files |
I think the issue here is that the HTML linters glob (asterisk wildcards) support is poor and on bash-based systems, bash expands the globs correctly, but on Windows the linter itself expands the glob incorrectly. |
however, note that the linter on windows DID find actual invalid HTML in the docs output. so i'd argue that the end result is more accurate on windows, so if it's somehow possible to change this part of the build script to behave like it does on windows even on a mac/linux machine, that'd be best (otherwise there'll always be the problem of further errors in the docs output that go undiscovered until somebody on windows runs the build script) |
This doesn't happen for me. Can we close it @patrickhlauke @bardiharborow ? |
with all the very latest npm stuff, i get a clean |
@patrickhlauke: the latter I fixed it a couple of days ago, see #24241. Surprisingly on Windows it was fine that is why it took me some time to notice it. |
Since updating to the new
npm
based build system, any attempts at building locally (just usingnpm test
) on my Windows machine results in a long list of errors thrown by htmllintbut it seems i'm the only one getting these? #22534 (comment)
this is on my local branch, which is sync'd and rebased with the latest
v4-dev
herei submitted #22500 to fix the above linting errors, but now i'm more fundamentally wondering why others may not be getting these linting errors. thoughts? /cc @Johann-S
The text was updated successfully, but these errors were encountered: