Fix build by installing grunt dependencies later #22534
Conversation
Johann-S
force-pushed
the
v4-test-fix-build
branch
from
f92d411 to
060a273
Compare
package.json
Outdated
| @@ -38,7 +38,9 @@ | |||
| "js-minify": "uglifyjs --compress warnings=false --mangle --comments '/^!/' --output dist/js/bootstrap.min.js dist/js/bootstrap.js", | |||
| "js-minify-docs": "uglifyjs --compress warnings=false --mangle --comments '/^!/' --output docs/assets/js/docs.min.js docs/assets/js/vendor/anchor.min.js docs/assets/js/vendor/clipboard.min.js docs/assets/js/vendor/holder.min.js docs/assets/js/src/application.js", | |||
| "js-test": "phantomjs ./node_modules/qunit-phantomjs-runner/runner.js js/tests/index.html 60", | |||
| "js-test-cloud": "ruby -run -ehttpd . -p3000 > /dev/null & grunt saucelabs-qunit", | |||
| "js-test-dep": "npm install grunt && npm install grunt-saucelabs", | |||
| "js-launch-cloud": "ruby -run -ehttpd . -p3000 > /dev/null & grunt saucelabs-qunit", | |||
Johann-S
force-pushed
the
v4-test-fix-build
branch
from
060a273 to
4606012
Compare
|
I spammed a lot SauceLabs 😂 so they don't want to run our unit test but It seems our build system is OK now ❤️ /CC @mdo and @bardiharborow |
|
speaking of fixed build system, am i the only one getting errors relating to markup linting when i try to run the new build system locally? #22500 |
|
EDIT : |
|
@Johann-S Can you expand of this change, I'm curious to know why you need to install grunt this way. Also, optional-dev-dependency might clean the code a bit. |
|
Because we install those nodes modules just when we want to run our tests on Saucelabs. So with this way we are sure that |
| @@ -38,7 +38,9 @@ | |||
| "js-minify": "uglifyjs --compress warnings=false --mangle --comments '/^!/' --output dist/js/bootstrap.min.js dist/js/bootstrap.js", | |||
| "js-minify-docs": "uglifyjs --compress warnings=false --mangle --comments '/^!/' --output docs/assets/js/docs.min.js docs/assets/js/vendor/anchor.min.js docs/assets/js/vendor/clipboard.min.js docs/assets/js/vendor/holder.min.js docs/assets/js/src/application.js", | |||
| "js-test": "phantomjs ./node_modules/qunit-phantomjs-runner/runner.js js/tests/index.html 60", | |||
| "js-test-cloud": "ruby -run -ehttpd . -p3000 > /dev/null & grunt saucelabs-qunit", | |||
| "js-test-dep": "npm install grunt && npm install grunt-saucelabs", | |||
There was a problem hiding this comment.
Did npm install & ruby -run [...] not work with these as dependencies? Was explicitly installing these the only way it worked?
There was a problem hiding this comment.
I just want to install these two dependencies that's why, npm install will install all the dependencies.
EDIT :
Sorry didn't understood well your sentence... My bad
Yes, I don't know why but grunt wasn't known as a program before I did that
But I think it's a good thing to remove grunt from devDependencies because we use grunt only to trigger cloud test on Saucelabs
Close : #22476