-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: outline badges #23886
New feature: outline badges #23886
Conversation
459329f
to
1a1a80e
Compare
1a1a80e
to
9c58cb4
Compare
@andresgalante: maybe change the light badge to use a darker background? As for the animation, personally I'd add it, but let's wait for @mdo to chime in. |
Is there any progress on getting this integrated? Currently I am using the button classes to get around this:
|
This is awesome: bump! |
Is there any update on this? Would love to see this merged. |
I would love this feature! I think it's better adding the same hover animation to badges as in |
I've made another PR which takes care of the focus state of default linked badges (#27136), this PR also adds the transition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. One thing though is this might need to update our print styles to somehow account for the colored borders. Perhaps a :not()
selector? See https://github.com/twbs/bootstrap/blob/v4-dev/scss/_print.scss#L103-L105.
Now, we can make a outlined badge by utility classes. Please reconsider the necessity of new specific classes. <span class="badge text-primary border border-primary">Primary outlined</span>
<span class="badge text-secondary border border-secondary">Secondary outlined</span> I think badges should have flexibility to allow various custom colors. Not only theme colors defined in Bootstrap. Please see #27149 or #27136 (comment) for more details. |
@ysds Yeah, there are discussions here and elsewhere around how to rollback badges in v5. Do we take that stance now, or do we keep adding and improving until then? Some things on my mind around badges:
Writing all that out, it feels like we say no to this in v4.x given their future in v5.x? |
Punting on this for now given recent conversation around scaling back badge functionality for utilities and better differentiation from buttons in v5. (Adding to our v5 planning doc.) |
This PR closes #23882
It adds outlined badges and they look like this:
Do you think it's worth adding the same hover animation to badges as in btns for consistency?