Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themed link focus state #27136

Merged
merged 7 commits into from
Dec 21, 2018
Merged

Themed link focus state #27136

merged 7 commits into from
Dec 21, 2018

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Aug 26, 2018

Fixes #27135.

This PR includes:

Before:

After:

Demo:
https://codepen.io/MartijnCuppens/pen/MqKMZv

@ysds
Copy link
Member

ysds commented Aug 28, 2018

My hope is this true opposite. I even want Bootstrap to remove the current hovering background color changes. In other words, I want simpler CSS, since labeling component basically requires more color variations. In some cases, service provider does not decide the color, but the user freely sets the color. e.g:

image

I'm worried that bootstrap away from flexible design system by adding complex CSS to badges.

@alecpl
Copy link
Contributor

alecpl commented Aug 29, 2018

I agree, clickable badges are just buttons. Bootstrap went too far with badges. I also would use badges with my custom colors. Maybe this should be reconsidered.

The focus outline on the Light badge is not visible here.

@ysds
Copy link
Member

ysds commented Aug 30, 2018

You can see my opinion in #27149.

@MartijnCuppens
Copy link
Member Author

I understand the concerns, I even didn't knew it was possible to use badges as links until I saw them in the docs. It might indeed be a good idea to remove them in the next major Bootstrap release because of the limited added value. But now that linked badges are available in v4, I think we should keep consistency between the bootstrap components and fix the focus outline.

That being said, if we decide not to apply these themed focus styles, the selector improvement is definitely something we should implement.

@andresgalante, what are your thoughts on this?

@andresgalante
Copy link
Collaborator

andresgalante commented Sep 13, 2018

Hi @MartijnCuppens, I think you have a point about consistency, and I agree with @alecpl, a clickable badge should be a btn.

@patrickhlauke what do you think about changing the focus ring on badges?

@mdo what do you think about rolling down the badge links features in next versions?

+1 for the selector change, if you want, open a new PR with that change so we can track different discussions in different places.

@MartijnCuppens MartijnCuppens changed the title Themed link focus state & selector improvement Themed link focus state Sep 19, 2018
@XhmikosR XhmikosR requested a review from a team as a code owner November 4, 2018 11:37
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to say we should nix this, but I think the focus improvement is actually a functional improvement for end users. Previously we discussed removing some badge functionality for v5, but I'm fine adding this until that release. Other badge changes will likely be paused though.

@mdo
Copy link
Member

mdo commented Dec 16, 2018

Going to hold for v4.2.1 btw.

@mdo mdo merged commit fc841b0 into twbs:v4-dev Dec 21, 2018
@mdo mdo mentioned this pull request Dec 21, 2018
@MartijnCuppens MartijnCuppens deleted the badge-link-focus branch December 22, 2018 12:38
@mdo mdo mentioned this pull request Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants