Prevent form validation mixin from generating invalid CSS #28447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally :) #26471 |
|
@wojtask9 Hah, sorry about that! Glad we could help you out now at least and follow-up on it :). |
13 tasks
Extrapolates the previously used selector into a new mixin that only generates valid CSS by creating psuedo-classes for `valid` and `invalid`, and nothing else. Fixes #28380.
XhmikosR
force-pushed
the
form-validation-selectors
branch
from
3c8e182
to
ab02e35
Compare
MartijnCuppens
approved these changes
Apr 24, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Apr 25, 2019
Extrapolates the previously used selector into a new mixin that only generates valid CSS by creating psuedo-classes for `valid` and `invalid`, and nothing else. Fixes #28380.
XhmikosR
pushed a commit
that referenced
this pull request
Apr 29, 2019
Extrapolates the previously used selector into a new mixin that only generates valid CSS by creating psuedo-classes for `valid` and `invalid`, and nothing else. Fixes #28380.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extrapolates the previously used selector into a new mixin that only generates valid CSS by creating psuedo-classes for
validandinvalid, and nothing else.Fixes #28380.