-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5: Update badges #28458
v5: Update badges #28458
Conversation
Please check the first demo on a button :) https://github.com/twbs/bootstrap/pull/28458/files#diff-f61d8731574dae0fcf82be95eabcf9f5R27 - Notifications <span class="badge badge-light">4</span>
+ Notifications <span class="badge bg-secondary">4</span> |
- Drop hover and focus states - Drop .badge-* variants and associated mixin for .bg-* utilities - Drop .badge-pill for .rounded-pill utliity and adjust horizontal padding to find middle ground of .badge and old .badge-pill - Remove unused variables - Add default color value to .badge base class - Update docs to reflect changes
This should be ready for review @twbs/css-review. Thanks @XhmikosR for rebasing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way better! I was thinking about combining the .btn
s and .badge
s into one component, but we'll get in trouble with the hover states if we do that.
First pass at updating the badge component per discussions in #27136, other threads, and our team Slack channel. Here's what's included thus far:
.badge-*
variants and associated mixin for.bg-*
utilities.badge-pill
for.rounded-pill
utility and adjust horizontal padding to find middle ground of.badge
and old.badge-pill
color
value to.badge
base class