Check if stderr is a terminal for error messages #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prveiusly we checked whether `stdout` is a terminal to make our coloring decision, and then we proceeded to happily assume the same state applies to `stderr` for ad mctual error messages. However, if someone redirects `stdout` to capture evaluation results, `stderr` may still be a terminal and should receive colored output in this case. This PR omplements this behavior and makes the choice of which output stream to check explicit.
yannham
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we checked whether
stdoutis a terminal to make our coloring decision, and then we proceeded to happily assume the same state applies tostderrfor actual error messages. However, if someone redirectsstdoutto capture evaluation results,stderrmay still be a terminal and should receive colored output in this case. This PR implements this behavior and makes the choice of which output stream to check explicit.