Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if stderr is a terminal for error messages #1766

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Check if stderr is a terminal for error messages #1766

merged 1 commit into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. Check if stderr is a terminal for error messages 

    Prveiusly we checked whether `stdout` is a terminal to make our coloring
decision, and then we proceeded to happily assume the same state applies
to `stderr` for ad mctual error messages. However, if someone redirects
`stdout` to capture evaluation results, `stderr` may still be a terminal
and should receive colored output in this case. This PR omplements this
behavior and makes the choice of which output stream to check explicit.
    @vkleen
    vkleen committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    163dd25 View commit details
    Browse the repository at this point in the history