-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only AirBnB iCalendars are supported #73
Comments
As an aside... |
The error string for a URL that returns bad data incorrectly states that AirBnB is the only supported calendar. This is incorrect as we now verify that the data returns is of type text/calendar and accept any calendar that passes this. Additionally, the error string for invalid URLs was not giving a reason why it was considered invalid. Issue: #73 Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
@IanAdd the error isn't actually very clear as to what is happening. When you try to submit the integration validates that the provided URL complies with the following two rules (text for both is being updated in #75)
For instance AirBnB returns the following with that command:
Whiel VRBO and Guesty return the following (respectively):
Alternatively, you can email me (or PM me on the HA forums) a URL that I can go and inspect for any oddities. As to your aside. Yes, that is sort of intended. What happens is that the selected timezone is applied to the calendar on the next calendar refresh (roughly every 2 minutes). Sensors refresh every 30ish seconds. The state description when it is being built is ignoring the the timezone in the date and time string conversion for the status. So it's going to effectively treat it as the timezone of the object is the "local" timezone for output. However, the start and end times are timezone aware and are treating everything correctly. Personally, I don't have calendars that are in timezones other than my local, but in my manual testing I've been adding one and sticking it on the other side of the world from me so that I can make sure that the objects that it really matters for are updating correctly. Having the status show the date time as the local to property makes it easier to know that it's doing the correct(ish) thing, particularly in the case where you might need to talk to a guest. You don't have to do the timezone conversion yourself then. |
I went to change the timezone of my two calendars which were working fine.
Amended airbnb no problem, just selected the timezone from the list and submitted, no other items touched.
Amending my Tripadvisor calendar's timezone and the message above popped up. Actually I'm unable to 'submit' even without making any change.
The text was updated successfully, but these errors were encountered: