Fix: Correct error strings #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error string for a URL that returns bad data incorrectly states that AirBnB is the only supported calendar. This is incorrect as we now verify that the data returns is of type text/calendar and accept any calendar that passes this. Additionally, the error string for invalid URLs was not giving a reason why it was considered invalid. Issue: #73 Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error string for a URL that returns bad data incorrectly states that
AirBnB is the only supported calendar. This is incorrect as we now
verify that the data returns is of type text/calendar and accept any
calendar that passes this.
Additionally, the error string for invalid URLs was not giving a reason
why it was considered invalid.
Issue: #73
Signed-off-by: Andrew Grimberg tykeal@bardicgrove.org