Delegate interpreting the yaml away from collection #152

delfick · 2024-05-04T13:12:31Z

For #144 I think it'll be useful if the yaml definition can be given more control over how the test actually runs it.

To help with that this PR makes it so that the pytest entry point is less responsible for those decisions, and that there is more separation between the raw definition and the processed idea of what the test should do.

I've split this PR into many commits to make it easier to see the small changes that happen as I move code around (best seen with the github ignore whitespace option).

The notable changes include

File is now defined in pytest_mypy_plugins.definition, but I've kept a reference to it from pytest_mypy_plugins.collect
When creating the File objects, it dosn't default path to "main.py" because it's mandatory in the schema so it should always have a value anyways
I made the skip logic not call eval if skip is a boolean or the strings "True" or "False"
made test_input_schema.py use SafeLineLoader
Changed the return annotations on the plugin entry point to be less specific as only pytest itself use them and it only cares about the more generic type
I changed how parse_parametrized works, I don't have strong opinions if the previous implementation is preferred.

Couple of unused imports and legacy fspath These were missed in that PR that removed support for pytest 6.x

This will make it easier to make the yaml able to do determine different things to be done when the test is run

It doesn't need to be accessed outside this module Also make File match the json schema we have (content is optional and defaults to empty, path is mandatory)

Also some changes to types and how parsing parametrized is implemented

We want to split up turning the raw item into a pytest.Item

This stayed as long as it did to make the git diff a bit more useful

In the beginning there was pytest-mypy-plugins as used by django-stubs and I needed the ability to test how mypy incremental and fine-grained caches interact with my mypy plugin. I created this issue on pytest-mypy-plugins asking if it were possible typeddjango/pytest-mypy-plugins#144 The answer was that this functionality wasn't in the plugin and PRs were welcome I made a few PRs including typeddjango/pytest-mypy-plugins#152 which was then the base for a couple more branches. Ultimately it was a lot of change and getting that merged wasn't a thing. After many months I decided to take what I had done in those branches and what I had here and create pytest-typing-runner as a more sophisticated, tested, documented, typed version of what I had written across those branches and this repo. The project should be able to handle more than just mypy, but that has yet to be done. Also I want to make it so that pytest-typing-runner can be used in django-stubs, which involves a few more additional features. The docs for the project are also in need of some more effort. But the pytest-typing-runner plugin is now fully tested and I'm happy with it's API, so I've released a version and made this project use it

In the beginning there was pytest-mypy-plugins as used by django-stubs and I needed the ability to test how mypy incremental and fine-grained caches interact with my mypy plugin. I created this issue on pytest-mypy-plugins asking if it were possible typeddjango/pytest-mypy-plugins#144 The answer was that this functionality wasn't in the plugin and PRs were welcome I made a few PRs including typeddjango/pytest-mypy-plugins#152 which was then the base for a couple more branches. Ultimately it was a lot of change and getting that merged wasn't a thing. After many months I decided to take what I had done in those branches and what I had here and create pytest-typing-runner as a more sophisticated, tested, documented, typed version of what I had written across those branches and this repo. The project should be able to handle more than just mypy, but that has yet to be done. Also I want to make it so that pytest-typing-runner can be used in django-stubs, which involves a few more additional features. The docs for the project are also in need of some more effort. But the pytest-typing-runner plugin is now fully tested and I'm happy with it's API, so I've released a version and made this project use it Also it appears that I need more control over when pytest-typing-runner loads vs my extension to it in this project and I've had to turn off pytest autoload to make this work, I will look at this next

In the beginning there was pytest-mypy-plugins as used by django-stubs and I needed the ability to test how mypy incremental and fine-grained caches interact with my mypy plugin. I created this issue on pytest-mypy-plugins asking if it were possible typeddjango/pytest-mypy-plugins#144 The answer was that this functionality wasn't in the plugin and PRs were welcome I made a few PRs including typeddjango/pytest-mypy-plugins#152 which was then the base for a couple more branches. Ultimately it was a lot of change and getting that merged wasn't a thing. After many months I decided to take what I had done in those branches and what I had here and create pytest-typing-runner as a more sophisticated, tested, documented, typed version of what I had written across those branches and this repo. The project should be able to handle more than just mypy, but that has yet to be done. Also I want to make it so that pytest-typing-runner can be used in django-stubs, which involves a few more additional features. The docs for the project are also in need of some more effort. But the pytest-typing-runner plugin is now fully tested and I'm happy with it's API, so I've released a version and made this project use it

delfick · 2024-09-09T03:57:38Z

Closing this as I've turned it and a bunch of other changes into it's own fork :) #144 (comment)

Removed unused code

eb41497

Couple of unused imports and legacy fspath These were missed in that PR that removed support for pytest 6.x

delfick force-pushed the schema/split-from-execution branch from bb170be to 3a39532 Compare May 4, 2024 13:21

delfick added 7 commits May 4, 2024 23:25

Extract yaml parsing from collection

c6f102b

This will make it easier to make the yaml able to do determine different things to be done when the test is run

Make parsing test files list a private function

2860ff3

It doesn't need to be accessed outside this module Also make File match the json schema we have (content is optional and defaults to empty, path is mandatory)

Make the other two parse functions private

7566ec4

Also some changes to types and how parsing parametrized is implemented

Put data onto the ItemDefinition itself

b319b42

We want to split up turning the raw item into a pytest.Item

Extracting processing of data into property methods

dd49e71

Remove the need for make_pytest_item

94f19e2

This stayed as long as it did to make the git diff a bit more useful

Avoid running eval for simple cases

7c561d5

delfick force-pushed the schema/split-from-execution branch from 3a39532 to 7c561d5 Compare May 4, 2024 13:27

delfick mentioned this pull request May 6, 2024

Testing changes and caching behaviour #144

Closed

delfick mentioned this pull request Aug 29, 2024

Convert from fork of pytest-mypy-plugins to pytest-typing-runner delfick/extended-mypy-django-plugin#57

Merged

delfick closed this Sep 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delegate interpreting the yaml away from collection #152

Delegate interpreting the yaml away from collection #152

delfick commented May 4, 2024

delfick commented Sep 9, 2024

Delegate interpreting the yaml away from collection #152

Delegate interpreting the yaml away from collection #152

Conversation

delfick commented May 4, 2024

delfick commented Sep 9, 2024