Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Epic#onMany to be called with many arguments #86

Merged
merged 4 commits into from
Sep 7, 2020
Merged

Enable Epic#onMany to be called with many arguments #86

merged 4 commits into from
Sep 7, 2020

Conversation

sisisin
Copy link
Contributor

@sisisin sisisin commented Jul 18, 2020

No description provided.

@lstkz
Copy link
Contributor

lstkz commented Jul 20, 2020

Does it work properly if there are multiple actions with different signatures?
Not sure, but I think typescript 4.0 is required microsoft/TypeScript#39094?

@sisisin sisisin force-pushed the feat/improve-array-to-tuple branch from 12da660 to c9ba041 Compare August 8, 2020 07:45
@sisisin
Copy link
Contributor Author

sisisin commented Aug 8, 2020

@lstkz I'm sorry for late response
I'd added this commit which covers actions with different signatures, how about this?

Epic#onMany signature uses Mapped tuple type (this is not Variadic tuple types ).
Mapped tuple type is supported from TypeScript 3.1( implemented at this PR )
Here is example on typescript playground

@lstkz lstkz merged commit f30a10d into typeless-js:master Sep 7, 2020
@lstkz
Copy link
Contributor

lstkz commented Sep 7, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisisin @lstkz