Resolve race condition in interruptibleMany after interruption
#3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
force-pushed
the
bug/interruptibleMany
branch
from
89a85e1
to
9124ef9
Compare
djspiewak
force-pushed
the
bug/interruptibleMany
branch
from
9124ef9
to
ea6f370
Compare
|
Released as I've run this on the reproducer several times and it appears to be fixed! |
Merged
armanbilge
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race condition here is that the busy-loop which spams interruption on the worker thread can continue to run after the interruption has been caught and handled. That… actually literally the point. This is problematic though because it means the worker thread will be returned to the pool in an interrupted state, which in turn shuts down the pool. The solution is to busy-wait (we can't hard-block because that would, itself, be interrupted) until the interruption loop is finished, and then finally clear the interrupted bit at the very end.
Fixes #3073