Try to fix #3075 #3081
Merged
Try to fix #3075 #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cancelled CI because it was hanging. But this is a problem you've inherited from #3074 :) |
|
Ok, thank you. Do we know why that happens? |
|
I don't, but maybe @djspiewak has a hunch? |
|
Yeah, it's a real deadlock. Let's see if this fixes it... |
|
Hey, looking good, nice work! 😃 |
|
Ah, I just got to this one! :-) You found the same bug that I found. It's fixed in the upstream PR now. I think that fixes everything? Let's see. |
|
@djspiewak Yes, I think so too. @armanbilge Done. |
djspiewak
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #3075. It is on top of #3074.
I've left alone two
whileloops:blockingcall, so it seems ok.Hopefully there are no semantic changes
(I've moved a.manyDone.set(true)from afinally, which might be a problem. But I didn't understand why it was in afinally...)