Fix effectful copyIn (Fixes #1512)
#1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The challenge faced here was to capture the number of affected rows when ending a `COPY`. To safely end a copy, it needs to be run in the finalizer of a `bracket`. We cannot retrieve values from a finalizer, so there was some logic in place to call `PFCI.endCopy` in two places and use `isActive` to determine if it should be called the second time. `isActive` seems to not be an `!isClosed`, but rather "is connection reserved for this Copy operation?". The fix is to replace the double closing with a reference
|
@jatcwang When you have time :) |
|
@oyvindberg Please bear with me. Busy with real world:tm: atm :sweat_smile: |
|
no worries @jatcwang , I know what that feels like :) |
jatcwang
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The challenge faced here was to capture the number of affected rows when ending a
COPY.To safely end a copy, it needs to be run in the finalizer of a
bracket. We cannot retrieve values from a finalizer, so there was some logic in place to callPFCI.endCopyin two places and useisActiveto determine if it should be called the second time.isActiveseems to not be an!isCopyEnded, but rather "is connection reserved for this Copy operation?".The fix is to replace the double closing with a reference