Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix effectful copyIn (Fixes #1512) #1567

Merged
merged 1 commit into from
Dec 10, 2021

Commits on Oct 7, 2021

  1. Fix effectful copyIn (Fixes typelevel#1512)

    The challenge faced here was to capture the number of affected rows when ending a `COPY`.
    To safely end a copy, it needs to be run in the finalizer of a `bracket`. We cannot retrieve values from a finalizer, so there was some logic in place to call `PFCI.endCopy` in two places and use `isActive` to determine if it should be called the second time. `isActive` seems to not be an `!isClosed`, but rather "is connection reserved for this Copy operation?".
    
    The fix is to replace the double closing with a reference
    oyvindberg committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    9414dc5 View commit details
    Browse the repository at this point in the history