Fix #60 when scalac options specified in ThisBuild scope by user are ignored #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user are ignored
|
Thanks @seveneves! I am going to follow this up with a PR to add the |
|
@DavidGregory084 is it possible to release this one? Thank you! |
|
@DavidGregory084 I created a PR that adds a couple of the useful source flags: #63 if it helps |
|
Sorry @seveneves I didn't mean to leave this one for so long! I have been sitting on a branch that does something similar to what @mihaisoloi has implemented in #63 for a while but I wasn't totally happy with it. @mihaisoloi has shown me that at least we both have the same idea so let's go ahead with it. I will merge together our changes tomorrow and release 0.2.3. For real this time! 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #60