Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source options #63

Closed
wants to merge 1 commit into from
Closed

Conversation

mihaisoloi
Copy link
Contributor

@mihaisoloi mihaisoloi commented Apr 12, 2022

The docs are lifted from here:

These are not enabled by default as they add a bunch of warnings even if the code is completely valid in the current Scala version.

@DavidGregory084
Copy link
Member

Thanks for this @mihaisoloi - I have actually been sitting on a PR that implements these flags because I couldn't think of a nice way to resolve the 2.x -Xsource vs 3.x -source inconsistency, so in a way it's a relief to see that you also went for scala3Source!
I'd like to compare what you have done here to my branch and merge the changes together since I went spelunking into the history of the ScalaSettings code in scala/scala and lampepfl/dotty to figure out when each flag was added.

@DavidGregory084
Copy link
Member

Thanks @mihaisoloi! This is superseded by #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants