Implementation of JWTAuthorizationProvider #1116
Conversation
|
|
worker/worker.go
Outdated
| @@ -173,6 +173,12 @@ type ( | |||
| Run() error | |||
| } | |||
|
|
|||
| AuthorizationProvider interface { | |||
There was a problem hiding this comment.
This is giving me a cyclic error @longquanzheng.
If I would like to place this on "go.uber.org/cadence/.gen/go/shared" but I'm wondering if everything inside of .gen is generated and if that's the case how could I generate that struct there? Or where do you recommend me to place it?
There was a problem hiding this comment.
Yeah don’t put it under .gen. There should be other places to put it . Would it work if you put it under auth/ ? And then use type aliases to export to public
internal/internal_worker.go
Outdated
| @@ -29,6 +29,7 @@ import ( | |||
| "encoding/hex" | |||
| "errors" | |||
| "fmt" | |||
| "go.uber.org/cadence/internal/common/auth" | |||
There was a problem hiding this comment.
This should be moved to the below section/group
internal/worker.go
Outdated
| @@ -225,6 +226,10 @@ type ( | |||
| // Optional: Flags to turn on/off some server side options | |||
| // default: all the features in the struct are turned off | |||
| FeatureFlags FeatureFlags | |||
|
|
|||
| // Optional: Authorization interface to get the Auth Token | |||
| // default: empty token | |||
There was a problem hiding this comment.
Default should be no provider
…adence-client into adding-auth-provider-interface
iamrodrigo
changed the title
|
@longquanzheng test added :), check |
…adence-client into adding-auth-provider-interface
Pull Request Test Coverage Report for Build ebefd216-b2af-484f-8ba4-55a8796259d8
💛 - Coveralls |
What changed?
Implementation of
JWTAuthorizationProviderin both worker and clientWhy?
Part of this proposal
How did you test it?
Running the server with oauth file
and modifying cadence-samples
Adding Authorization value in NewClient here
Adding Authorization value in NewDomainClient here
Adding Authorization value in worker.Options here
Potential risks
None