Replace JWT library for signing tokens #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantas-sidlauskas
requested review from
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
reviewed
Feb 13, 2024
| @@ -22,6 +22,7 @@ package auth | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/golang-jwt/jwt/v5" | |||
There was a problem hiding this comment.
separate std imports from others.
Unrelated @Groxx Should we onboard client to gci too?
| if err != nil { | ||
| return nil, err | ||
|
|
||
| ttl := int64(60 * 10) |
There was a problem hiding this comment.
why it is hardcoded? Should it be configurable?
There was a problem hiding this comment.
No sure why this was hard-coded during the initial implementation but my take is this: this ttl is for internal/self-signed tokens. There are no external calls to acquire a token, there's no caching involved, they are issued for every request, in other words, they are cheap and should be short lived.
internal/jwt_authorization_test.go
Outdated
| @@ -21,60 +21,41 @@ | |||
| package internal | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
| "io/ioutil" | |||
| "github.com/stretchr/testify/assert" | |||
mantas-sidlauskas
force-pushed
the
jwt_library
branch
from
c138c81
to
d94b61c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Claimswith "Registered claims" from https://www.rfc-editor.org/rfc/rfc7519#section-4.1ExpiresAtbut also keeping TTL for backwards compatibilityWhy?
To align with upcoming server changes
How did you test it?
Unit tests
Potential risks