Use sync/atomic, drop external atomics #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches all uses of go.uber.org/atomic to types defined in sync/atomic. These types have been available since Go 1.19, which is the minimum supported version of Go for Zap. This allows us to drop one dependency from Zap. The version of multierr was bumped to pick up uber-go/multierr#72 which made a similar change to that package. This was nearly a drop-in, save the following: - There's no `Int*.Inc`; we have to use `Int*.Add(1)` - There's no `Bool.Toggle`; we have to implement the CAS loop manually
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 49 49
Lines 3231 3231
=======================================
Hits 3174 3174
Misses 49 49
Partials 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches all uses of go.uber.org/atomic to types defined in sync/atomic.
These types have been available since Go 1.19,
which is the minimum supported version of Go for Zap.
This allows us to drop one dependency from Zap.
The version of multierr was bumped to pick up uber-go/multierr#72
which made a similar change to that package.
This was nearly a drop-in, save the following:
Int*.Inc; we have to useInt*.Add(1)Bool.Toggle; we have to implement the CAS loop manuallyThis change has no user-facing consequences
because nearly all atomic usages are internal to Zap.
The only atomic exposed (AtomicLevel) is a wrapper type
for which the behavior does not change.