Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sync/atomic, drop external atomics #1253

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Use sync/atomic, drop external atomics #1253

merged 1 commit into from
Mar 19, 2023

Commits on Mar 19, 2023

  1. Use sync/atomic, drop external atomics

    Switches all uses of go.uber.org/atomic to types defined in sync/atomic.
    These types have been available since Go 1.19,
    which is the minimum supported version of Go for Zap.
    
    This allows us to drop one dependency from Zap.
    The version of multierr was bumped to pick up uber-go/multierr#72
    which made a similar change to that package.
    
    This was nearly a drop-in, save the following:
    
    - There's no `Int*.Inc`; we have to use `Int*.Add(1)`
    - There's no `Bool.Toggle`; we have to implement the CAS loop manually
    abhinav committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    0629789 View commit details
    Browse the repository at this point in the history