-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Kotlin extension functions to main artifact #339
Conversation
This preserves binary compatibility by using a different file name at the jvm level (`KotlinExtensions`) while adopting the Retrofit-style approach of making the kotlin extensions directly available and making the stdlib dep optional
by marking these hidden, should make the new ones "just work" for consumers since the imports are the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
Can we remove the autodispose-ktx
in sample
? That way we can make sure that it's a drop-in replacement.
Also looks like AnimalSniffer isn't playing well with the compileOnly
. Do we want to run it on tests?
autodispose/src/main/java/com/uber/autodispose/KotlinExtensions.kt
Outdated
Show resolved
Hide resolved
autodispose/src/test/java/com/uber/autodispose/AutoDisposeKotlinTest.kt
Outdated
Show resolved
Hide resolved
I forgot about intrinsics. Let's just make it |
This preserves binary compatibility by using a different file name at the jvm level (
KotlinExtensions
) while adopting the Retrofit-style approach of making the kotlin extensions directly available and making the stdlib dep optional.This also marks the existing -ktx version as deprecated with
HIDDEN
severity. This makes this basically seamless for consumers where the imports are unchanged.If this looks good, we can make passes to move the other ktx functions too