Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Kotlin extension functions to main artifact #339

Merged
merged 6 commits into from
Apr 5, 2019
Merged

Move Kotlin extension functions to main artifact #339

merged 6 commits into from
Apr 5, 2019

Commits on Apr 4, 2019

  1. Copy in AutoDispose extensions to main artifact with new JvmName 

    This preserves binary compatibility by using a different file name at the jvm level (`KotlinExtensions`) while adopting the Retrofit-style approach of making the kotlin extensions directly available and making the stdlib dep optional
    @ZacSweers
    ZacSweers committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    f10f144 View commit details
    Browse the repository at this point in the history

  2. Deprecate existing autodispose extensions 

    by marking these hidden, should make the new ones "just work" for consumers since the imports are the same
    @ZacSweers
    ZacSweers committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    864ecf2 View commit details
    Browse the repository at this point in the history

  3. Add proguard rule for ignoring extensions

    @ZacSweers
    ZacSweers committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    e493e11 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Make stdlib implementation for intrinsics

    @ZacSweers
    ZacSweers committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    1c5caba View commit details
    Browse the repository at this point in the history

  2. Remove autodispose-ktx from sample project

    @ZacSweers
    ZacSweers committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    7f0dd24 View commit details
    Browse the repository at this point in the history

  3. Remove autodispose-ktx entirely 

    No longer necessary!
    @ZacSweers
    ZacSweers committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    f3c7dc1 View commit details
    Browse the repository at this point in the history