Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Switch to using Golang modules support #250

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Switch to using Golang modules support #250

merged 2 commits into from
Dec 20, 2018

Conversation

bufdev
Copy link
Contributor

@bufdev bufdev commented Dec 20, 2018

Two switches in a day. This switches dependencies to be tracked using Golang modules. This is much faster, as well as allows an extremely simple install using go get github.com/uber/prototool/cmd/prototool@VERSION.

Fixes #192.

This removes yarpc and grpc-gateway from the example, as this was the only place these were used, as well as removes any internal generation using gogo/protobuf, instead using golang/protobuf which is what this library depends on internally.

This temporarily removes linting using errcheck, staticcheck, unused until they are resolved in golang/go#24661, but the tradeoff to be able to use Golang modules is worth it IMO.

@codecov-io
Copy link

Codecov Report

Merging #250 into dev will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #250      +/-   ##
==========================================
- Coverage   71.16%   71.12%   -0.05%     
==========================================
  Files          90       90              
  Lines        4495     4495              
==========================================
- Hits         3199     3197       -2     
- Misses        946      948       +2     
  Partials      350      350
Impacted Files Coverage Δ
internal/settings/settings.go 55.55% <0%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5794c37...55ca915. Read the comment docs.

@bufdev
Copy link
Contributor Author

bufdev commented Dec 20, 2018

Specific tracking issue for errcheck to work with Golang modules: kisielk/errcheck#155

@bufdev
Copy link
Contributor Author

bufdev commented Dec 20, 2018

Specific tracking issue for staticcheck, unused to work with Golang modules: dominikh/go-tools#328

@bufdev bufdev merged commit 231fd54 into dev Dec 20, 2018
@bufdev bufdev deleted the gomod branch December 20, 2018 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from glide to vgo and move internal/cmd/prototool back to cmd/prototool
3 participants