This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Switch to using Golang modules support #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #250 +/- ##
==========================================
- Coverage 71.16% 71.12% -0.05%
==========================================
Files 90 90
Lines 4495 4495
==========================================
- Hits 3199 3197 -2
- Misses 946 948 +2
Partials 350 350
Continue to review full report at Codecov.
|
|
Specific tracking issue for errcheck to work with Golang modules: kisielk/errcheck#155 |
|
Specific tracking issue for staticcheck, unused to work with Golang modules: dominikh/go-tools#328 |
konradjniemiec
approved these changes
Dec 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two switches in a day. This switches dependencies to be tracked using Golang modules. This is much faster, as well as allows an extremely simple install using
go get github.com/uber/prototool/cmd/prototool@VERSION.Fixes #192.
This removes yarpc and grpc-gateway from the example, as this was the only place these were used, as well as removes any internal generation using gogo/protobuf, instead using golang/protobuf which is what this library depends on internally.
This temporarily removes linting using errcheck, staticcheck, unused until they are resolved in golang/go#24661, but the tradeoff to be able to use Golang modules is worth it IMO.