Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Delete ldflags binding and fix go install #253

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Delete ldflags binding and fix go install #253

merged 1 commit into from
Dec 21, 2018

Conversation

bufdev
Copy link
Contributor

@bufdev bufdev commented Dec 21, 2018

After #250, GitCommit and BuiltTimestamp are no longer binding properly, but these were always extraneous, and these don't get bound if you do go get github.com/uber/prototool/cmd/prototool anyways. They should just be removed. This also fixes make install to properly install the binary from source, as opposed to fetching it.

@bufdev bufdev merged commit 661b913 into dev Dec 21, 2018
@bufdev bufdev deleted the delete-ldflags branch December 21, 2018 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants