Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): clean up workflow names #1433

Merged
merged 3 commits into from
Jun 27, 2024
Merged

chore(ci): clean up workflow names #1433

merged 3 commits into from
Jun 27, 2024

Conversation

castrojo
Copy link
Member

No description provided.

@castrojo castrojo enabled auto-merge June 23, 2024 18:57
p5
p5 previously approved these changes Jun 23, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we aren't doing Aurora as well, we should probably have Bluefin in the title.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it just be one workflow for both?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no. We have brand_name as an input which is how bluefin or Aurora is decided to be built.

Even as I think about GTS vs Latest, I may have to completely restructure the matrix for the reusable build to handle across versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could possibly look into some sort of matrix option on our current workflow to add coreOS as a build option

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone the merged route so this workflow won't be needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll just wait post-coreos kernel and then reapply what makes sense.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 27, 2024
@castrojo castrojo added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@m2Giles m2Giles added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 572c841 Jun 27, 2024
58 checks passed
@m2Giles m2Giles deleted the org-workflows branch June 27, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants