Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): clean up workflow names #1433

Merged
merged 3 commits into from
Jun 27, 2024
Merged

chore(ci): clean up workflow names #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f23ee5
chore(ci): clean up workflow names
castrojo Jun 23, 2024
b09440e
Merge branch 'main' into org-workflows
m2Giles Jun 27, 2024
69abb2f
chore(ci): Aurora Name
m2Giles Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-39-aurora.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: aurora 39
name: Aurora 39
on:
merge_group:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-39-bluefin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: bluefin 39
name: Bluefin 39
on:
merge_group:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-40-aurora.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: aurora 40
name: Aurora 40
on:
merge_group:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-40-bluefin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: bluefin 40
name: Bluefin 40
on:
merge_group:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-aurora-iso.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Aurora ISO Build
name: Aurora ISO
on:
workflow_dispatch:
schedule:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-bluefin-gts-iso.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Bluefin GTS ISO Build
name: Bluefin GTS ISO
on:
workflow_dispatch:
schedule:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-bluefin-latest-iso.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Bluefin Latest ISO Build
name: Bluefin Latest ISO
on:
workflow_dispatch:
schedule:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-coreos-aurora.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: aurora coreos
name: Aurora Stable
on:
merge_group:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-coreos-bluefin.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we aren't doing Aurora as well, we should probably have Bluefin in the title.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it just be one workflow for both?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no. We have brand_name as an input which is how bluefin or Aurora is decided to be built.

Even as I think about GTS vs Latest, I may have to completely restructure the matrix for the reusable build to handle across versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could possibly look into some sort of matrix option on our current workflow to add coreOS as a build option

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone the merged route so this workflow won't be needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll just wait post-coreos kernel and then reapply what makes sense.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: bluefin coreos
name: Bluefin Stable
on:
merge_group:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-build-iso.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Reusable Build ISOs
name: Reusable ISO
on:
workflow_call:
inputs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build and Push Image
name: Reusable Build and Push
on:
workflow_call:
inputs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-image-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Scan Image
name: Scan and SBOM
on:
workflow_call:
inputs:
Expand Down
Loading