(PXP-9480): Support merge param for PUT /resource endpoint #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2022
Avantol13
requested changes
Feb 14, 2022
| @@ -1105,6 +1105,35 @@ func TestServer(t *testing.T) { | |||
| getResourceWithPath(t, "/Godel,/completeness_theorem") | |||
| }) | |||
|
|
|||
| t.Run("Merge", func(t *testing.T) { | |||
There was a problem hiding this comment.
we could maybe add one more test or command in here that updates an existing subresource instead of top level. So like update the dog resource, add goldenretriever or something. What's the behavior if you do that but leave out corgi? I assume it also stays around?
There was a problem hiding this comment.
Yeah the expected behavior would be that corgi stays around.
Avantol13
approved these changes
Feb 15, 2022
15 tasks
This was referenced Jun 14, 2022
Merged
This was referenced Jun 21, 2022
Merged
Merged
This was referenced Jul 26, 2022
Merged
This was referenced Aug 3, 2022
This was referenced Aug 10, 2022
This was referenced Aug 23, 2022
This was referenced Oct 20, 2022
Closed
This was referenced Nov 21, 2022
This was referenced Dec 18, 2023
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-9480
As part of improving DRS endpoint performance, to enable creating multiple study resources with a single request and not have existing
/programssubresources overwritten, support amergeparam for thePUT /resourceendpoint.Corresponding PRs
New Features
mergeparam forPUT /resourceendpoint so that existing subresources are not overwritten