Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen3 Monthly Release 2022.06 nci-crdc.datacommons.io 1655926264 #4782

Merged

Conversation

PlanXCyborg
Copy link
Contributor

Applying version 2022.06 to nci-crdc.datacommons.io

@PlanXCyborg PlanXCyborg requested review from trevars and a team as code owners June 22, 2022 19:31
@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

  • fence
    • URL Signing when no_force_sign query param is provided: Previously Fence would make a decision based off if the data was public and no_force_sign provided. Fence will now NEVER sign if no_force_sign is provided (since the concept of "public" data has been abstracted out of Fence. Data access - public or not - is the sole responsibility of the policy engine). In other words, if no_force_sign is provided at the API level, Fence will respect that regardless of whether the resulting URL will actually work. The default Fence behavior should remain the same. chore(jupyter-nde1.1.0) #988 (Feat/passport fence#964)

@PlanXCyborg PlanXCyborg added the test-apis-dbgapTest run dbgap tests only label Jun 28, 2022
@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

  • fence
    • URL Signing when no_force_sign query param is provided: Previously Fence would make a decision based off if the data was public and no_force_sign provided. Fence will now NEVER sign if no_force_sign is provided (since the concept of "public" data has been abstracted out of Fence. Data access - public or not - is the sole responsibility of the policy engine). In other words, if no_force_sign is provided at the API level, Fence will respect that regardless of whether the resulting URL will actually work. The default Fence behavior should remain the same. chore(jupyter-nde1.1.0) #988 (Feat/passport fence#964)

Copy link
Contributor

@MaribelleHGomez MaribelleHGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atharvar28 atharvar28 merged commit 2156411 into master Jun 30, 2022
@atharvar28 atharvar28 deleted the chore/apply_202206_to_nci-crdc_datacommons_io_1655926265 branch June 30, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-apis-dbgapTest run dbgap tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants