Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen3 Monthly Release 2022.12 nci-crdc.datacommons.io 1670653953 #5457

Merged

Conversation

PlanXCyborg
Copy link
Contributor

Applying version 2022.12 to nci-crdc.datacommons.io

@PlanXCyborg PlanXCyborg requested review from frankliuao and a team as code owners December 10, 2022 06:32
@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

Copy link
Contributor

@frankliuao frankliuao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monthly Gen3 release added to the manifest. Approved.

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

frankliuao
frankliuao previously approved these changes Jan 10, 2023
Copy link
Contributor

@frankliuao frankliuao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes and approving it to run CI

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

1 similar comment
@PlanXCyborg
Copy link
Contributor Author

nci-crdc.datacommons.io/manifest.json

Deployment changes

Breaking changes

@atharvar28
Copy link
Contributor

The PR is consistently failing dbGaP tests, might be a configuration issue in GCP. Team is working on fixing it. Force merging due to delay by 2 weeks

@frankliuao
Copy link
Contributor

Thank you @BinamB and @atharvar28. This is a special occasion where the deployment can't be held off any longer and we know the code is not breaking production because it has been in staging for almost a month now, plus the team has looked into the tests carefully. Nevertheless, I am responsible for recommending this special exception and for the consequences of it.

@m0nhawk m0nhawk merged commit 2fed384 into master Jan 19, 2023
@m0nhawk m0nhawk deleted the chore/apply_202212_to_nci-crdc_datacommons_io_1670653954 branch January 19, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants