Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tube): Fixed tube etl mapping #83

Merged
merged 3 commits into from
Apr 13, 2021
Merged

fix(tube): Fixed tube etl mapping #83

merged 3 commits into from
Apr 13, 2021

Conversation

victorskl
Copy link
Contributor

New Features

  • Featuring docker-compose.override.yml to keep the base
    docker compose config clean

Bug Fixes

Improvements

  • Allowed ES cluster in either green or yellow mode
  • Added esdata volume for ES persistent
  • Updated Fence user.yaml template to align with common
    use cases as written guide in README
  • Updated tip and workaround in README

* Updated etl mapping and gitops to support tube node id
  naming convention using underscore. See
  uc-cdis/tube#131
* Allowed ES cluster in either `green` or `yellow` mode
* Added `esdata` volume for ES persistent
* Updated Fence `user.yaml` template to align with common
  use cases as written guide in README
* Updated tip and workaround in README
* Featuring `docker-compose.override.yml` to keep the base
  docker compose config clean
Copy link
Contributor

@xritter1 xritter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let me get more reviews for this PR.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docker-compose.override.sample.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@thanh-nguyen-dang thanh-nguyen-dang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

README.md Outdated Show resolved Hide resolved
* Updated README
* Updated comment

Co-authored-by: xritter1 <67650599+xritter1@users.noreply.github.com>
@victorskl
Copy link
Contributor Author

Thanks @xritter1 for pointers. I've applied all the suggestions.

README.md Outdated Show resolved Hide resolved
Co-authored-by: xritter1 <67650599+xritter1@users.noreply.github.com>
@xritter1 xritter1 merged commit 0e82730 into uc-cdis:master Apr 13, 2021
@victorskl victorskl deleted the fix/tube-etl-mapping branch April 13, 2021 23:11
victorskl added a commit to umccr/gen3-doc that referenced this pull request Apr 13, 2021
* Upstream PR #83 for tube etl fix is now merged
  See uc-cdis/compose-services#83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants