-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tube): Fixed tube etl mapping #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated etl mapping and gitops to support tube node id naming convention using underscore. See uc-cdis/tube#131 * Allowed ES cluster in either `green` or `yellow` mode * Added `esdata` volume for ES persistent * Updated Fence `user.yaml` template to align with common use cases as written guide in README * Updated tip and workaround in README * Featuring `docker-compose.override.yml` to keep the base docker compose config clean
xritter1
reviewed
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Let me get more reviews for this PR.
thanh-nguyen-dang
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
xritter1
reviewed
Apr 8, 2021
* Updated README * Updated comment Co-authored-by: xritter1 <67650599+xritter1@users.noreply.github.com>
Thanks @xritter1 for pointers. I've applied all the suggestions. |
xritter1
reviewed
Apr 12, 2021
Co-authored-by: xritter1 <67650599+xritter1@users.noreply.github.com>
victorskl
added a commit
to umccr/gen3-doc
that referenced
this pull request
Apr 13, 2021
* Upstream PR #83 for tube etl fix is now merged See uc-cdis/compose-services#83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
docker-compose.override.yml
to keep the basedocker compose config clean
Bug Fixes
naming convention using underscore. See
fix(project_id): ensure project_id exists tube#131
Improvements
green
oryellow
modeesdata
volume for ES persistentuser.yaml
template to align with commonuse cases as written guide in README