fix(project_id): ensure project_id exists #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanh-nguyen-dang
force-pushed
the
fix/project_id_not_exist
branch
from
a0be004
to
1385bab
Compare
m0nhawk
approved these changes
Jul 29, 2020
thanh-nguyen-dang
force-pushed
the
fix/project_id_not_exist
branch
from
9a09036
to
692ef0d
Compare
thanh-nguyen-dang
force-pushed
the
fix/project_id_not_exist
branch
from
fd24f91
to
9fbb696
Compare
|
This pull request fixes 1 alert when merging 9fbb696 into 3619fa3 - view on LGTM.com fixed alerts:
|
thanh-nguyen-dang
force-pushed
the
fix/project_id_not_exist
branch
from
1c8e31a
to
ea5db77
Compare
paulineribeyre
approved these changes
Jul 29, 2020
thanh-nguyen-dang
force-pushed
the
fix/project_id_not_exist
branch
2 times, most recently
from
4c5d202
to
ae15886
Compare
thanh-nguyen-dang
force-pushed
the
fix/project_id_not_exist
branch
from
ae15886
to
e384448
Compare
|
This pull request fixes 1 alert when merging e384448 into 3619fa3 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 34c37ff into 3619fa3 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 83d2306 into 3619fa3 - view on LGTM.com fixed alerts:
|
thanh-nguyen-dang
force-pushed
the
fix/project_id_not_exist
branch
from
83d2306
to
1071126
Compare
paulineribeyre
approved these changes
Jul 30, 2020
|
This pull request fixes 4 alerts when merging 1071126 into 3619fa3 - view on LGTM.com fixed alerts:
|
This was referenced Dec 19, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue when project_id does not exist in project node in aggregation index.
Features
Bug Fixes
Deployment Changes
{subject,case,file}_idfields. Requires migrating gitops.json and etlMapping.yaml following these instructions: 1. Make a list of all thedoc_typefields in etlMapping.yaml. 2. Change any instance of{doc_type}_idto_{doc_type}_idin gitops.json and etlMapping.yaml. (E.g. ifdoc_typeissubject, replace all instances ofsubject_idin etlMapping.yaml and gitops.json with_subject_id). 3. If there is no change to the etlMapping in the PR, manually add a comment to the etlMapping or change the order of two props in order to force gitops-sync to run the ETL.