-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/mds adapter #29
Merged
Merged
Feat/mds adapter #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/mds/agg_mds/adapters.py
Outdated
Comment on lines
402
to
433
if adapter_name == "icpsr": | ||
gather = ISCPSRDublin(mds_url) | ||
json_data = gather.getRemoteDataAsJson(filters=filters) | ||
results = gather.normalizeToGen3MDSFields( | ||
json_data, | ||
mappings=mappings, | ||
perItemValues=perItemValues, | ||
keepOriginalFields=keepOriginalFields, | ||
) | ||
return results | ||
if adapter_name == "clinicaltrials": | ||
gather = ClinicalTrials(mds_url) | ||
json_data = gather.getRemoteDataAsJson(filters=filters) | ||
results = gather.normalizeToGen3MDSFields( | ||
json_data, | ||
mappings=mappings, | ||
perItemValues=perItemValues, | ||
keepOriginalFields=keepOriginalFields, | ||
) | ||
return results | ||
if adapter_name == "pdaps": | ||
gather = PDAPS(mds_url) | ||
json_data = gather.getRemoteDataAsJson(filters=filters) | ||
results = gather.normalizeToGen3MDSFields( | ||
json_data, | ||
mappings=mappings, | ||
perItemValues=perItemValues, | ||
keepOriginalFields=keepOriginalFields, | ||
) | ||
return results | ||
else: | ||
raise Exception(f"unknown adapter for commons: {name}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if adapter_name == "icpsr": | |
gather = ISCPSRDublin(mds_url) | |
json_data = gather.getRemoteDataAsJson(filters=filters) | |
results = gather.normalizeToGen3MDSFields( | |
json_data, | |
mappings=mappings, | |
perItemValues=perItemValues, | |
keepOriginalFields=keepOriginalFields, | |
) | |
return results | |
if adapter_name == "clinicaltrials": | |
gather = ClinicalTrials(mds_url) | |
json_data = gather.getRemoteDataAsJson(filters=filters) | |
results = gather.normalizeToGen3MDSFields( | |
json_data, | |
mappings=mappings, | |
perItemValues=perItemValues, | |
keepOriginalFields=keepOriginalFields, | |
) | |
return results | |
if adapter_name == "pdaps": | |
gather = PDAPS(mds_url) | |
json_data = gather.getRemoteDataAsJson(filters=filters) | |
results = gather.normalizeToGen3MDSFields( | |
json_data, | |
mappings=mappings, | |
perItemValues=perItemValues, | |
keepOriginalFields=keepOriginalFields, | |
) | |
return results | |
else: | |
raise Exception(f"unknown adapter for commons: {name}") | |
adapters = {"icpsr": ISCPSRDublin, "clinicaltrials": ClinicalTrials, "pdaps": PDAPS} | |
if adapter_name in adapters: | |
adapter = adapters[adapter_name] | |
gather = adapter(mds_url) | |
json_data = gather.getRemoteDataAsJson(filters=filters) | |
results = gather.normalizeToGen3MDSFields( | |
json_data, | |
mappings=mappings, | |
perItemValues=perItemValues, | |
keepOriginalFields=keepOriginalFields, | |
) | |
return results | |
else: | |
raise Exception(f"unknown adapter for commons: {name}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
John like your suggestion, as I refactored this section in my branch, I incorporated it.
Handle unexpected input data
This was referenced Nov 30, 2021
Closed
This was referenced Dec 10, 2021
This was referenced Jan 10, 2022
Closed
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This was referenced Feb 3, 2022
This was referenced Feb 16, 2022
This was referenced Feb 23, 2022
Merged
This was referenced Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: HP-255
This PR is a companion to uc-cdis/cloud-automation#1649
New Features
Breaking Changes
Bug Fixes
Deployment changes
AGG_MDS_NAMESPACE
value inmetadata.env