Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init submodule script leaves gitconfig in modified state if submodule update fails #595

Closed
colinschmidt opened this issue Jun 5, 2020 · 0 comments
Labels

Comments

@colinschmidt
Copy link
Contributor

Impact: software

Tell us about your environment:
Chipyard Version: 1.3

What is the current behavior?
If I have modifications in a submodule that would be updated by init-submodules-no-riscv-tools.sh the git submodule update command will fail and cause the script to exit early, leaving some of the git config *.update none commands to remain in effect.

What is the expected behavior?
The script should catch this error and return the git config back to the initial state before exiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant