Ensure git config changes are reverted on failure #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0u
force-pushed
the
init-submodules-gitconfig
branch
from
65dbae1
to
d66825f
Compare
a0u
commented
Jan 14, 2021
a0u
force-pushed
the
init-submodules-gitconfig
branch
from
d66825f
to
36fe690
Compare
|
Merging to move forwards with release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #595
Type of change: bug fix
Impact: other
Release Notes
This ensures that the temporary
git configsettings for excluding certain submodules from the recursive update are properly reverted if the submodule update fails or is interrupted by SIGINT or SIGTERM.The git commands have been refactored to loop over a centralized blacklist, which should reduce the potential for human errors when updating this script in the future.