Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SiFive submodules to CHIPS fork #1208

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

michael-etzkorn
Copy link
Contributor

SiFive versions of repos will no longer be actively maintained so they've been transferred over to Chipsalliance.

Related PRs / Issues:

#1171

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@michael-etzkorn
Copy link
Contributor Author

I can't add a changelog label, but the label would be omit.

@michael-etzkorn
Copy link
Contributor Author

michael-etzkorn commented Aug 16, 2022

I'll fix the CI run commit check for this over the weekend, but feel free to scoop me to that.

@michael-etzkorn
Copy link
Contributor Author

@jerryz123 This should now pass the check-commit CI job. fpga-shells' main branch is now named main and I've updated the script to reflect that.

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez merged commit 3cd952b into ucb-bar:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants