Teach TLTileResetCtrl about TileResetDomain #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking at this. I don't believe we currently have any software which tests this, but for now it should be sufficient to verify that the default configs still work. |
|
I've confirmed that bumping rocket to latest master hits this problem and then using this gets past it in the scala compile, only to hit compile issues in BOOM. I'm going to start a CY branch and PR for bumping rocket for the upcoming release. |
timsnyder-siv
added a commit
to ucb-bar/chipyard
that referenced
this pull request
Dec 18, 2020
jerryz123
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #110
@jerryz123 and @davidbiancolin I'm going to bump RC in a clone of chipyard and try doing some FireSim builds. Please let me know if there's something specific that will test that the TLTileResetCtrl is working as intended.
@hcook if you have a chance to take a look at this and see if it makes sense. It compiles but I have a feeling that I might be missing something here.