fix: prevent suggestions from being active when editor is readonly #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2 tasks
|
Looks good to me. Thanks for your submission ☀️ |
|
It seems like there are linting issues in your code. could you resolve them @scottsidwell? |
scottsidwell
force-pushed
the
fix/prevent-active-suggestions-when-read-only
branch
from
16f277c
to
c680cca
Compare
|
@bdbch thanks for flagging, fixed :) |
scottsidwell
force-pushed
the
fix/prevent-active-suggestions-when-read-only
branch
from
c680cca
to
45990cd
Compare
|
Thanks! Merged :) |
|
@bdbch Is there any chance a new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The suggestions extension will continue to react to selection changes even when the editable is "readonly", which can lead to it showing a pop-up for text that start with the trigger character. This was discovered in #2680.
See the demo below:
Screen.Recording.2022-04-08.at.3.01.26.pm.mov
Fix
We need to ensure we don't attempt to detect a suggestion at the current selection when isEditable is false. The attached commit will fail-fast and cleanup any active suggestion state. Demo:
Screen.Recording.2022-04-08.at.3.07.36.pm.mov